Fix invalid occurrences for BYDAY rrules #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this! If you rebase on master it should make the CI green |
fmeringdal
approved these changes
Apr 1, 2024
|
Thanks so much for the fix @sciyoshi! @fmeringdal Would it be possible to create a release for this bugfix? |
|
Yes, a new release is coming this week. |
|
Awesome! Thank you! |
|
Version 0.12.0 is now published to crates.io 🎉 |
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104. When incrementing a monthly RRULE, the end of month check breaks recurrences if the new counter date falls outside of the month's date range. Instead of using
increment_yearly, just update theyearto avoid the call tofix_day.